-
Notifications
You must be signed in to change notification settings - Fork 403
Update tutorial.md #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tutorial.md #633
Conversation
WalkthroughUpdated documentation text in docs/tutorial.md: two Card descriptions now reference comparisons with Express and Hono versus Elysia, replacing prior mentions of tRPC. No code or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/tutorial.md (1)
49-58
: Replace hard tabs with spaces (markdownlint MD010)Lines 51, 52, 54, and 57 contain tabs. Convert to spaces to satisfy markdownlint and keep indentation consistent.
Apply:
- Comparison between Express and Elysia + Comparison between Express and Elysia - Comparison between Fastify and Elysia + Comparison between Fastify and Elysia - Comparison between Hono and Elysia + Comparison between Hono and Elysia
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/tutorial.md
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
docs/tutorial.md
51-51: Hard tabs
Column: 1
(MD010, no-hard-tabs)
52-52: Hard tabs
Column: 1
(MD010, no-hard-tabs)
54-54: Hard tabs
Column: 3
(MD010, no-hard-tabs)
57-57: Hard tabs
Column: 3
(MD010, no-hard-tabs)
🔇 Additional comments (3)
docs/tutorial.md (3)
51-52
: Copy tweak LGTM“Comparison between Express and Elysia” reads correctly and matches the card’s link.
57-58
: Copy tweak LGTM“Comparison between Hono and Elysia” is clear and consistent with the link.
49-58
: Resolved — target migration pages existBoth /migrate/from-express and /migrate/from-hono are present (docs/migrate/from-express.md, docs/migrate/from-hono.md); the cards will not 404.
Summary by CodeRabbit