Fix path issue in Scalar config #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
bump. this fixes my issue when Scalar UI tries to load the openapi schema from |
dodas
reviewed
Feb 21, 2025
Co-authored-by: Jozef Mikuláš <[email protected]>
dodas
approved these changes
Feb 21, 2025
|
Could we please have it merged @SaltyAom ? |
|
This got merged, but it's still not working in Elysia 1.3.1 and this package 1.3.0 |
|
I believe this is a regression in either [email protected] or @elysiajs/[email protected]. |
|
Still not working as it should, have to resort to this workaround.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a prefix, the plugin tries to fetch the scalar config from an incorrect path as mentioned in issues #161, #183, #151 . This can be seen in the screenshots below.
This PR enables successful fetching of the Scalar config from the correct URL whether a prefix is used or not and even if the prefix is nested.
closes #161
closes #183
closes #151
closes #157