Skip to content

[breadcrumb] custom prefix + icons + docs #1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 13, 2020
Merged

[breadcrumb] custom prefix + icons + docs #1901

merged 12 commits into from
Jul 13, 2020

Conversation

ericdallo
Copy link
Member

@ericdallo ericdallo commented Jul 12, 2020 •
edited
Loading

  • Fix a hardcoded extension 😅
  • Add support for icons from treemacs if available
  • Add lsp-headerline-breadcrumb-prefix suggested here and change breadcrumb documentation related:

image

@ericdallo ericdallo self-assigned this Jul 12, 2020
@ericdallo ericdallo added this to the Next release milestone Jul 12, 2020
@ericdallo ericdallo changed the title Breadcrumb custom prefix [breadcrumb] add custom prefix + docs Jul 12, 2020
@ericdallo ericdallo changed the title [breadcrumb] add custom prefix + docs [breadcrumb] custom prefix +icons + docs Jul 12, 2020
@ericdallo ericdallo changed the title [breadcrumb] custom prefix +icons + docs [breadcrumb] custom prefix + icons + docs Jul 12, 2020
@ericdallo ericdallo requested a review from yyoncho July 13, 2020 13:25
@yyoncho
Copy link
Member

yyoncho commented Jul 13, 2020

  1. Can you remove the first space?
  2. Can you use different faces file path and for the symbol path?

@ericdallo
Copy link
Member Author

Done @yyoncho!

@ericdallo ericdallo force-pushed the breadcrumb-custom-prefix branch from f0d2e78 to da0792b Compare July 13, 2020 16:41
@ericdallo ericdallo force-pushed the breadcrumb-custom-prefix branch from da0792b to 97deb2b Compare July 13, 2020 16:55
yyoncho
yyoncho approved these changes Jul 13, 2020
View reviewed changes
@ericdallo ericdallo force-pushed the breadcrumb-custom-prefix branch from fe106e3 to 74b67e6 Compare July 13, 2020 17:04
@ericdallo
Copy link
Member Author

Updated Docs:
image

@ericdallo ericdallo merged commit 392e69a into master Jul 13, 2020
@ericdallo ericdallo deleted the breadcrumb-custom-prefix branch July 13, 2020 18:27
@yyoncho yyoncho mentioned this pull request Jul 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yyoncho yyoncho yyoncho approved these changes

Assignees

@ericdallo ericdallo

Labels

None yet

Projects

None yet

Milestone

7.0.1

Development

Successfully merging this pull request may close these issues.

2 participants

@ericdallo @yyoncho