embassy-stm32: Added ability for SPI driver to function in slave mode #4388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmilatinov
force-pushed
the
feature/stm32-spi-slave
branch
from
6e73f2d to
c4b9e59
Compare
|
Neat, if this gets accepted I'd like to do something similar for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This PR adds the ability to create an SPI driver instance in slave mode. I have taken inspiration from the I2C driver for the added traits. The original master SPI driver API is left intact.
From the reference manual and STM32 HAL SPI driver source, it seems as though the only extra step required to run in slave mode is to disable the SSM and SSI bits in the SPI control registers.
Two new functions are added to allow for construction of a slave blocking and non-blocking driver, namely
Spi::new_blocking_slaveandSpi::new_slave(with an extra NSS parameter of course).I have tested this on the STM32F723ZE with success. Please let me know if I have missed something in the implementation as I am still quite new to driver development.
Cheers