Fix incorrect I2C OA2 bit shift #4692
Open
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innermatrix
force-pushed
the
stm32-fix-i2c-oa2
branch
from
8d9a60b to
ff972af
Compare
Also fix comment about OA2 masks to match the reference manual
innermatrix
force-pushed
the
stm32-fix-i2c-oa2
branch
from
ff972af to
ce6e44d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already a bit shift inside
set_oa2so this one is unnecessary and wrong. The net result was that passing inOA2ofnwould end up setting the secondary address ton<<1.Also fix comment about
OA2masks to match the reference manual