Skip to content

Conversation

@iddey
Copy link
Contributor

@iddey iddey commented Oct 10, 2025

Thank you for helping out with embedded-graphics-simulator development! Please:

  • Check that you've added passing tests and documentation
  • Add an example where applicable
  • Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, etc) if your changes affect the public API
  • Run rustfmt on the project
  • Run just build (Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.

PR description

I’d like to have the re-exported sdl2 crate dependency updated to the latest version. With Rust 1.90.0, I’ve started getting crashes running my examples that use the simulator due to a change that was made to the compiler: rust-lang/rust#141759

There’s probably an issue with sdl2-compat in my Linux installation, and sdl2 0.37.0 isn’t handling some error gracefully:

trying to construct an enum from an invalid value 0x207

My debug builds are crashing because of event.rs#L336 — already known about and fixed 9 months ago: rust-sdl2#1444

Updating sdl2 to 0.38.0 would allow me to continue running apps that use the simulator the same way they used to do when built with Rust 1.89.0 and earlier, irrespective of the fact that there’s an invalid value 0x207 in the app.

Copy link
Member

@rfuest rfuest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this issue. It has come up before in #68, but I somehow lost track of it and forgot to create a new release.

@rfuest rfuest merged commit 48c9aa7 into embedded-graphics:master Oct 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants