Skip to content

fix(rel): hex pub #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 28, 2025
Merged

fix(rel): hex pub #360

merged 4 commits into from
Jul 28, 2025

Conversation

qzhuyan
Copy link
Collaborator

@qzhuyan qzhuyan commented Jul 25, 2025

No description provided.

@coveralls
Copy link

coveralls commented Jul 26, 2025

Pull Request Test Coverage Report for Build 16544115583

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 4 files lost coverage.
  • Overall coverage remained the same at 86.485%

Files with Coverage Reduction New Missed Lines %
c_src/quicer_config.c 1 87.75%
src/quicer_lib.erl 1 82.35%
c_src/quicer_stream.c 2 89.84%
c_src/quicer_dgram.c 3 83.33%
Totals Coverage Status
Change from base Build 16193387938: 0.0%
Covered Lines: 4102
Relevant Lines: 4743

💛 - Coveralls

@qzhuyan qzhuyan requested a review from Copilot July 26, 2025 11:56
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes the hex publication by introducing a version override mechanism for releases. The changes allow the version to be set via the QUICER_VERSION environment variable instead of relying solely on git tags.

  • Adds a rel.mk file to define version configuration
  • Updates build scripts to use QUICER_VERSION environment variable as fallback
  • Modifies the application source to include additional release-related files

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/quicer.app.src Adds release-related files to the application source and removes "c_build" entry
rel.mk New file with commented version definition for release configuration
pkgname.sh Updates version detection to use QUICER_VERSION environment variable as fallback
build.sh Updates tag detection to use QUICER_VERSION environment variable as fallback
Makefile Includes rel.mk file for version configuration

@qzhuyan qzhuyan merged commit 99d751e into emqx:main Jul 28, 2025
54 of 57 checks passed
@qzhuyan qzhuyan deleted the fix/hex-pub branch July 28, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants