Test more edge cases in test_unlink #16396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test that open files can still be read or written after they are unlinked and that open directories can still be read after they are unlinked but that they cannot gain new children. Somewhat surprisingly, the old filesystem implementation passes this test with no modifications. WasmFS cannot run it because it does not have an implementation of `unlinkat`, and even if it did, it still would not pass.
Member
Author
|
Landing this because most tests have passed, even if their results haven't been reported back to GitHub. The only test failures cannot possibly be related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that open files can still be read or written after they are unlinked and
that open directories can still be read after they are unlinked but that they
cannot gain new children.
Somewhat surprisingly, the old filesystem implementation passes this test with
no modifications. WasmFS cannot run it because it does not have an
implementation of
unlinkat, and even if it did, it still would not pass.