-
Notifications
You must be signed in to change notification settings - Fork 45
Description
Before anything, please, if rebuild on changes will not be added as part of the json file then put it on the diff options because I'm sure most users tend to completely miss it out and for what I have experienced it never modifies the project's json file so I imagine it's a local user setting.
Now the issue is build_base behaviour. In Discord I reported having issues with it as I completely missed the point of it. The documentation says:
If true, objdiff will build the base objects before diffing (e.g.
make path/to/base.o).
So it's working as intended, however, this makes the feature of rebuild on changes confusing as despite of disabling it, it still rebuilding the object to compare when switching to another object file when the feature gives the idea that the program will not do any sort of rebuild.
As suggestion I would change the rebuild on changes behaviour to be base off upon build_base so if the project have it enable or disabled then it will consider it, but also giving the option to the user to force to enable it or disable it. In other way too see it, move it from the project configuration to Diff Option section and make it have three options: default (base off build_base in the project), on and off. Also if the project have no build intruction configured then it will ignore it the option in case of forcing yes.
Even if what I'm saying above is not going to be considered, at least fix the bug which by disabling build_base on the json file causes the build button to not work.