Fix illegal pattern in a function pointer type #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/parser/nodes.rs
Outdated
| pub node: TreeNode, | ||
| /// The handler which is executed once this node has been accepted. | ||
| pub handler: Option<fn(&node: Node) -> ()>, | ||
| pub handler: Option<fn(node: Node) -> ()>, |
There was a problem hiding this comment.
This should actually be node: &Node probably as I don't mean for the handler to consume the node. Right?
There was a problem hiding this comment.
Looks like that, updated.
Also, one more illegal pattern fixed.
|
Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crate was broken by a recent bugfix in
rustc(see rust-lang/rust#35015).Here's a fix.