Fix fw_log uninitialised mutex with tunable #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 2, 2020 10:11
as after that we might get into the log functions passing the bitmask and would panic as the mutex would not be initialised. Fixes Issue erikarn#31. Sponsored by: Rubicon Communications, LLC (d/b/a "Netgate")
erikarn
force-pushed
the
master
branch
2 times, most recently
from
c55dc6b to
f1c00bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialise the firmware_log early on before the tunables are read
as after that we might get into the log functions passing the
bitmask and would panic as the mutex would not be initialised.
Fixes Issue #31.
Sponsored by: Rubicon Communications, LLC (d/b/a "Netgate")