athp: cleanup modules build Makefiles #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 16, 2020 12:44
The Makefiles had a lot of copy and paste and especially CLEANFILES was wrong in most of them. Rather than keeping the duplicate logic everywhere, put it into a common Makefile.inc and only have the per-firmware kmod specifics in the individual Makefiles. This will also allow us to change the way we are building the firmware(9) kernel modules in a single place. Sponsored by: Rubicon Communications, LLC (d/b/a "Netgate")
For the moment the firmware is still in sys/contrib/dev/athp and not ath10k. For clarity and to avoid confusion we should consider to put it into an ath10k directory when it goes into HEAD. Sponsored by: Rubicon Communications, LLC (d/b/a "Netgate")
erikarn
force-pushed
the
master
branch
2 times, most recently
from
c55dc6b to
f1c00bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Makefiles had a lot of copy and paste and especially CLEANFILES
was wrong in some of them.
Rather than keeping the duplicate logic everywhere, put it into
a common Makefile.inc and only have the per-firmware kmod specifics
in the individual Makefiles.
This will also allow us to change the way we are building the
firmware(9) kernel modules in a single place.
Sponsored by: Rubicon Communications, LLC (d/b/a "Netgate")