Skip to content

Mtx lock null #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Mtx lock null #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
1de1fee
changed timeout to 2 seconds
Geramy Sep 6, 2018
d7ac970
took back the change.
Geramy Sep 7, 2018
1c8a86d
add code to force the driver to attempt to retry to load the interfac…
Geramy Sep 7, 2018
2572021
re-order
Geramy Sep 7, 2018
164b16c
re-trying probe fw until sucessful or errors at the 6th try.
Geramy Sep 7, 2018
7cfa1b5
undo changes
Geramy Sep 7, 2018
d9c1fa0
attempt at retrying to wait for htc to complete and return
Geramy Sep 7, 2018
fcadd32
removed return on hif_stop
Geramy Sep 7, 2018
a937079
attemping to recall ath10k_core_probe_fw
Geramy Sep 7, 2018
24c3912
add sleep statement
Geramy Sep 7, 2018
1a7bec9
dumb auto programming features of VSCode capatilized Sleep
Geramy Sep 7, 2018
067685e
not use to freebsd kernel developing.
Geramy Sep 7, 2018
8370fbe
added in a ath10k_core_stop
Geramy Sep 7, 2018
e9c6867
oops forgot semicolon
Geramy Sep 7, 2018
1f18574
test removing ath10k_core_stop from retrying probe and just hack bmi.…
Geramy Sep 7, 2018
31d612b
cleaened up my hack for probe retrying
Geramy Sep 7, 2018
0e6f097
forgot struct def
Geramy Sep 7, 2018
30041e5
added function to cleanup memory leaks
Geramy Sep 7, 2018
ed95bc6
removed pause_sig
Geramy Sep 15, 2018
f8035ce
removed line of code from ath10k
Geramy Sep 29, 2018
c9c1c35
add null check.
Geramy Nov 5, 2018
451782d
used wrong case
Geramy Nov 5, 2018
a81df9c
added some mutex checking
Geramy Nov 5, 2018
4dcb7db
forgot &
Geramy Nov 5, 2018
d00dac9
chaned from 3 seconds to 1 didnt do anything.
Geramy Nov 5, 2018
ad31d5d
removing annoying warnings
Geramy Nov 5, 2018
86e4ea5
Merge remote-tracking branch 'upstream/master'
Geramy Nov 5, 2018
b535d14
Revert "removing annoying warnings"
Geramy Nov 6, 2018
3fa625d
Revert "Revert "removing annoying warnings""
Geramy Nov 6, 2018
56c3d3e
Merge branch 'master' into mtx_lock_null
Geramy Nov 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion otus/freebsd/src/sys/dev/athp/ath10k/htt_rx.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1473,7 +1473,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
*/

if (!rx_status->freq) {
ath10k_warn(ar, "no channel configured; ignoring frame(s)!\n");
//ath10k_warn(ar, "no channel configured; ignoring frame(s)!\n");
return false;
}

Expand Down
2 changes: 1 addition & 1 deletion otus/freebsd/src/sys/dev/athp/if_athp_core.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1710,7 +1710,7 @@ attempt_ath10k_core_probe_fw(struct ath10k *ar, int anum)
{
int status = ath10k_core_probe_fw(ar);
if (status) {
ath10k_err(ar, "could not probe fw, clean up allocations and memory and retry. (%d)\n", status);
ath10k_err(ar, "could not probe fw, clean up allocations, memory and retry. (%d)\n", status);
tsleep(ar, 1, "pausing to wait for the ath cpu to be ready.", 250);
if(anum < ATH10K_FW_PROBE_RETRIES) {
clean_ath10k_core_probe_fw(ar);
Expand Down
25 changes: 15 additions & 10 deletions otus/freebsd/src/sys/dev/athp/if_athp_fwlog.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1550,18 +1550,23 @@ ath10k_fwlog_print_work(void *arg, int npending)
void
ath10k_handle_fwlog_msg(struct ath10k *ar, struct athp_buf *skb)
{
ATHP_FWLOG_LOCK(ar);
if(ar != NULL && mtx_initialized(&ar->fwlog_mtx) != 0) {
ATHP_FWLOG_LOCK(ar);

if (ar->fwlog_tx_queue_len > ATH10K_FWLOG_MAX_EVT_QUEUE) {
ath10k_warn(ar, "reached fwlog queue limit\n");
athp_freebuf(ar, &ar->buf_rx, skb);
return;
}
if (ar->fwlog_tx_queue_len > ATH10K_FWLOG_MAX_EVT_QUEUE) {
ath10k_warn(ar, "reached fwlog queue limit\n");
athp_freebuf(ar, &ar->buf_rx, skb);
return;
}

TAILQ_INSERT_TAIL(&ar->fwlog_tx_queue, skb, next);
ar->fwlog_tx_queue_len++;
taskqueue_enqueue(ar->workqueue, &ar->fwlog_tx_work);
ATHP_FWLOG_UNLOCK(ar);
TAILQ_INSERT_TAIL(&ar->fwlog_tx_queue, skb, next);
ar->fwlog_tx_queue_len++;
taskqueue_enqueue(ar->workqueue, &ar->fwlog_tx_work);
ATHP_FWLOG_UNLOCK(ar);
}
else {
//log that mutext is being locked upon and has never been initialized.
}
}

void ath10k_fwlog_register(struct ath10k *ar)
Expand Down
2 changes: 1 addition & 1 deletion otus/freebsd/src/sys/dev/athp/if_athp_htt_rx.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2034,7 +2034,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
*/

if (!rx_status->c_ieee) {
ath10k_warn(ar, "no channel configured; ignoring frame(s)!\n");
//ath10k_warn(ar, "no channel configured; ignoring frame(s)!\n");
return false;
}

Expand Down