Skip to content

Conversation

@cappuc
Copy link

@cappuc cappuc commented Oct 17, 2025

Description

bump facebook sdk to v23. This also fix some deprecation warning with php 8.4 (fixed in newer facebook sdk)

How has this been tested?

  • Unit tests
  • Integration tests
  • Manual testing

Copilot AI review requested due to automatic review settings October 17, 2025 20:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Bump facebook/php-business-sdk to v23 to resolve PHP 8.4 deprecation warnings and align internal event payload with the new SDK expectations.

  • Update composer constraint to ^23.0 for facebook/php-business-sdk.
  • Adjust setEvents call to pass a plain array instead of a collection.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/ConversionsApi.php Pass events as an array to the Facebook SDK (likely required by v23).
composer.json Bump facebook/php-business-sdk from ^19.0 to ^23.0.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant