`Buffer.slice` is deprecated

[jimmywarting]

It was bad that they overrided it in the first place...
https://nodejs.org/dist/latest-v18.x/docs/api/buffer.html#bufslicestart-end

Buffer don't even have a slice method that did the correct thing. slice is only an alias for subarray. and subarray is what ppl should have been using instead.

[aladdin-add]

PRs are welcome! 👍

[scagood]

I have been thinking about this one while updating the es-syntax.

I think we should look to move definePrototypeMethodHandler from eslint-plugin-es-x into @eslint-community/eslint-utils

I think its the best solution to adding prototype deprecation warnings. The one change I would make would be to make the callback required. 🤔

I was looking for a similar thing here too -- #180 (comment)

Something like:

import { definePrototypeMethodHandler } from "@eslint-community/eslint-utils"

definePrototypeMethodHandler(
  context,
  { Buffer: ["slice"] },
  ({ node }) => context.report({
    node: node,
    messageId: "buffer#slice-deprecated"
  }),
)

What do you think @aladdin-add?

[aladdin-add]

Is this still an issue? @scagood

[scagood]

I think it's a great thing to do... But I am not sure about the feasibility of it.

I think it'd be great to track the prototypal depreciation and support, but I am starting to think it may be a little too hard 😔

[aladdin-add]

Well, let's just document its limitations, and close this one. :)

[scagood]

Yeah, agreed.