chore: add release-please #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scagood
reviewed
Jan 18, 2024
.github/workflows/release-please.yml
Outdated
Comment on lines
18
to
19
| package-name: 'espree' | ||
| pull-request-title-pattern: 'chore: release${component} ${version}' |
There was a problem hiding this comment.
I think that the default here is fine 🤔
Its probably the same for the change logs
This is the default:
.github/workflows/release-please.yml
Outdated
| pull-requests: write | ||
| id-token: write | ||
| steps: | ||
| - uses: google-github-actions/release-please-action@v3 |
There was a problem hiding this comment.
It may be worth using v4 so we dont start behind 👀
aladdin-add
force-pushed
the
aladdin-add-patch-1
branch
from
b9c73a6 to
885d24a
Compare
Author
|
It's still in the prerelease process for v17, so it may still need to be configured. Until then I'll still use release-it for releases. |
This was referenced May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.