Skip to content

Update installation chapter #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Feb 1, 2023
Merged

Update installation chapter #62

merged 22 commits into from
Feb 1, 2023

Conversation

@SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Jan 23, 2023 •
edited
Loading

Rendered view:

@georgik @MabezDev @bjoernQ @JurajSadel @jessebraham any feedback/suggestion is more than welcome!

@SergioGasquez SergioGasquez mentioned this pull request Jan 23, 2023
Closed
6 tasks
@SergioGasquez SergioGasquez linked an issue Jan 23, 2023 that may be closed by this pull request
Setting Up a Development Environment #63
Closed
bjoernQ
bjoernQ reviewed Jan 23, 2023
View reviewed changes
jessebraham
jessebraham reviewed Jan 23, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, just took a quick look through. Will do a more thorough read some other time.

MabezDev
MabezDev reviewed Jan 23, 2023
View reviewed changes
SergioGasquez and others added 2 commits January 24, 2023 10:00
@SergioGasquez @jessebraham
docs: Fix typo
d4a0e30 
Co-authored-by: Jesse Braham <[email protected]>
@SergioGasquez @jessebraham
docs: Fix typo
0674c01 
Co-authored-by: Jesse Braham <[email protected]>
@SergioGasquez SergioGasquez marked this pull request as ready for review January 24, 2023 18:12
This was linked to issues Jan 24, 2023
Update libtinfo5 error #54
Closed
Document _latest tags #55
Closed
jessebraham
jessebraham reviewed Jan 30, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, left a few more comments. I think I've addressed all my concerns at this point.

@SergioGasquez
Copy link
Member Author

Thank you all for the feedback, just addressed the comments!

jessebraham
jessebraham approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing those comments. I think this is probably fine to merge!

@jessebraham
Copy link
Member

jessebraham commented Jan 31, 2023 •
edited
Loading

Oh I didn't notice, there are apparently merge conflicts (unless GitHub is lying to me again...) so those will need resolving first, obviously. If GitHub is lying to me again feel free to merge yourself @SergioGasquez

MabezDev
MabezDev requested changes Jan 31, 2023
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a revert of my previous comment (sorry again!) then this LGTM :)

@SergioGasquez SergioGasquez merged commit a5f703b into esp-rs:overhaul Feb 1, 2023
@SergioGasquez SergioGasquez deleted the fix/installation branch February 1, 2023 09:10
@SergioGasquez SergioGasquez mentioned this pull request Feb 10, 2023
Closed
@SergioGasquez SergioGasquez mentioned this pull request Mar 2, 2023
Closed
SergioGasquez added a commit to SergioGasquez/book that referenced this pull request Apr 27, 2023
@SergioGasquez @jessebraham
Update installation chapter (esp-rs#62)
e0cccda 
* docs: 📝 Initial rework of installation chapter

* docs: 📝 Add build diagram

* docs: 📝 Update riscv section

* docs: 📝 Update riscv section

* docs: 📝 Update Xtensa section

* chore: 🔥 Remove build process

* style: 🎨 Format troubleshooting chapter

* docs: 📝 Update export paths

* docs: 📝 Update libtinfo5 error

* docs: 📝 Fix typos

* fix: 🐛 Fix tests

* fix: 🐛 Fix link

* fix: 🐛 Fix link

* docs: 🐛 Fix note on `no_std` targets

* chore: ⚡️ Minor updates to simplify instructions

* docs: Fix typo

Co-authored-by: Jesse Braham <[email protected]>

* docs: Fix typo

Co-authored-by: Jesse Braham <[email protected]>

* docs: Update insallation methods order

Co-authored-by: Jesse Braham <[email protected]>

* docs: 📝 Address comments

* docs: 📝 Address comments

* docs: 📝 Update default no_std riscv target

---------

Co-authored-by: Jesse Braham <[email protected]>
jessebraham added a commit that referenced this pull request May 2, 2023
@SergioGasquez @jessebraham
Update installation chapter (#62)
32a0720 
* docs: 📝 Initial rework of installation chapter

* docs: 📝 Add build diagram

* docs: 📝 Update riscv section

* docs: 📝 Update riscv section

* docs: 📝 Update Xtensa section

* chore: 🔥 Remove build process

* style: 🎨 Format troubleshooting chapter

* docs: 📝 Update export paths

* docs: 📝 Update libtinfo5 error

* docs: 📝 Fix typos

* fix: 🐛 Fix tests

* fix: 🐛 Fix link

* fix: 🐛 Fix link

* docs: 🐛 Fix note on `no_std` targets

* chore: ⚡️ Minor updates to simplify instructions

* docs: Fix typo

Co-authored-by: Jesse Braham <[email protected]>

* docs: Fix typo

Co-authored-by: Jesse Braham <[email protected]>

* docs: Update insallation methods order

Co-authored-by: Jesse Braham <[email protected]>

* docs: 📝 Address comments

* docs: 📝 Address comments

* docs: 📝 Update default no_std riscv target

---------

Co-authored-by: Jesse Braham <[email protected]>
SergioGasquez added a commit to SergioGasquez/book that referenced this pull request May 30, 2023
@SergioGasquez @jessebraham
Update installation chapter (esp-rs#62)
01312af 
* docs: 📝 Initial rework of installation chapter

* docs: 📝 Add build diagram

* docs: 📝 Update riscv section

* docs: 📝 Update riscv section

* docs: 📝 Update Xtensa section

* chore: 🔥 Remove build process

* style: 🎨 Format troubleshooting chapter

* docs: 📝 Update export paths

* docs: 📝 Update libtinfo5 error

* docs: 📝 Fix typos

* fix: 🐛 Fix tests

* fix: 🐛 Fix link

* fix: 🐛 Fix link

* docs: 🐛 Fix note on `no_std` targets

* chore: ⚡️ Minor updates to simplify instructions

* docs: Fix typo

Co-authored-by: Jesse Braham <[email protected]>

* docs: Fix typo

Co-authored-by: Jesse Braham <[email protected]>

* docs: Update insallation methods order

Co-authored-by: Jesse Braham <[email protected]>

* docs: 📝 Address comments

* docs: 📝 Address comments

* docs: 📝 Update default no_std riscv target

---------

Co-authored-by: Jesse Braham <[email protected]>
SergioGasquez added a commit to SergioGasquez/book that referenced this pull request May 30, 2023
@SergioGasquez @jessebraham
Update installation chapter (esp-rs#62)
7c8e1a7 
* docs: 📝 Initial rework of installation chapter

* docs: 📝 Add build diagram

* docs: 📝 Update riscv section

* docs: 📝 Update riscv section

* docs: 📝 Update Xtensa section

* chore: 🔥 Remove build process

* style: 🎨 Format troubleshooting chapter

* docs: 📝 Update export paths

* docs: 📝 Update libtinfo5 error

* docs: 📝 Fix typos

* fix: 🐛 Fix tests

* fix: 🐛 Fix link

* fix: 🐛 Fix link

* docs: 🐛 Fix note on `no_std` targets

* chore: ⚡️ Minor updates to simplify instructions

* docs: Fix typo

Co-authored-by: Jesse Braham <[email protected]>

* docs: Fix typo

Co-authored-by: Jesse Braham <[email protected]>

* docs: Update insallation methods order

Co-authored-by: Jesse Braham <[email protected]>

* docs: 📝 Address comments

* docs: 📝 Address comments

* docs: 📝 Update default no_std riscv target

---------

Co-authored-by: Jesse Braham <[email protected]>
SergioGasquez added a commit that referenced this pull request May 31, 2023
@SergioGasquez @jessebraham
Update installation chapter (#62)
9a72519 
* docs: 📝 Initial rework of installation chapter

* docs: 📝 Add build diagram

* docs: 📝 Update riscv section

* docs: 📝 Update riscv section

* docs: 📝 Update Xtensa section

* chore: 🔥 Remove build process

* style: 🎨 Format troubleshooting chapter

* docs: 📝 Update export paths

* docs: 📝 Update libtinfo5 error

* docs: 📝 Fix typos

* fix: 🐛 Fix tests

* fix: 🐛 Fix link

* fix: 🐛 Fix link

* docs: 🐛 Fix note on `no_std` targets

* chore: ⚡️ Minor updates to simplify instructions

* docs: Fix typo

Co-authored-by: Jesse Braham <[email protected]>

* docs: Fix typo

Co-authored-by: Jesse Braham <[email protected]>

* docs: Update insallation methods order

Co-authored-by: Jesse Braham <[email protected]>

* docs: 📝 Address comments

* docs: 📝 Address comments

* docs: 📝 Update default no_std riscv target

---------

Co-authored-by: Jesse Braham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjoernQ bjoernQ bjoernQ left review comments

@MabezDev MabezDev MabezDev requested changes

@jessebraham jessebraham jessebraham approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Setting Up a Development Environment Document _latest tags Update libtinfo5 error

4 participants

@SergioGasquez @jessebraham @bjoernQ @MabezDev