Add ESP32-C2 support #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
reviewed
Nov 6, 2023
|
PR should be now ready to review but not yet tested |
MabezDev
reviewed
Nov 7, 2023
jessebraham
reviewed
Nov 8, 2023
Co-authored-by: Jesse Braham <[email protected]>
MabezDev
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
LGTM, thanks!
Feel free to create a PR upstream in probe-rs, or let me know if you want someone else to take care of that. You can use my H2 PR as a reference: probe-rs/probe-rs#1862. @jessebraham will be able to confirm, but the watchdog reset sequence should be the same as the esp32c3, so you can merge those two together when adding the RISCV reset sequence (like I did with H2 and C6).
|
Upstream PR created: probe-rs/probe-rs#1869 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.