Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@jessebraham
Copy link
Member

@jessebraham jessebraham commented Oct 6, 2022

No real code changes here, I've split the work up across commits for review purposes:

  • Run cargo fmt on the repository to make everything homogenous
  • Remove glob imports from modules (I think these make the code harder to reason about when reading)
  • Address any stable clippy warnings (this is in preparation of adding CI)

I have a separate branch ready with the CI configuration as well, however it will fail until this PR is merged so I've held off on opening a PR for it.

@jessebraham jessebraham requested a review from MabezDev October 6, 2022 16:22
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jessebraham jessebraham merged commit e9825ed into esp-rs:main Oct 7, 2022
@jessebraham jessebraham deleted the fixes/cleanup branch October 7, 2022 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants