- 
                Notifications
    
You must be signed in to change notification settings  - Fork 348
 
Timers runtime isr binding #1348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f013eb1    to
    39fa214      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I left a stupid nitpick :D
I didn't test all examples on all targets though, I tested new ones and randomly picked a few others.
1ac1cec    to
    4ed878b      
    Compare
  
    8609b7e    to
    de14dd7      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long for getting to this. I think most of my concerns have been resolved in the meantime, so for the sake of getting this merged LGTM!
| 
           Looks like the HIL tests need updating  | 
    
de14dd7    to
    febf92a      
    Compare
  
    
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
This implements runtime ISR binding for SYSTIMER and TIMG. It makes Systimer's DelayNs implementation available when the
asyncfeature is active.Two new examples are added
embassy_systimer_delay.rs- uses the DelayNs implementationembassy_hello_world_systimer.rs- same asembassy_hello_worldbut using the systimer time-driver (not for ESP32 or ESP32-S2), I added it since we currently don't check that driver (and also to test my changes)Testing
Running the existing (adapted) examples and added examples