Skip to content

Conversation

@bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Mar 26, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • My changes were added to the CHANGELOG.md in the proper section.

Extra:

Pull Request Details 📖

Description

This implements runtime ISR binding for SYSTIMER and TIMG. It makes Systimer's DelayNs implementation available when the async feature is active.

Two new examples are added

  • embassy_systimer_delay.rs - uses the DelayNs implementation
  • embassy_hello_world_systimer.rs - same as embassy_hello_world but using the systimer time-driver (not for ESP32 or ESP32-S2), I added it since we currently don't check that driver (and also to test my changes)

Testing

Running the existing (adapted) examples and added examples

@bjoernQ bjoernQ force-pushed the timers-runtime-isr-binding branch from f013eb1 to 39fa214 Compare March 26, 2024 14:10
@bjoernQ bjoernQ marked this pull request as ready for review March 26, 2024 14:42
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I left a stupid nitpick :D
I didn't test all examples on all targets though, I tested new ones and randomly picked a few others.

@bjoernQ bjoernQ force-pushed the timers-runtime-isr-binding branch 2 times, most recently from 1ac1cec to 4ed878b Compare March 27, 2024 16:16
@bjoernQ bjoernQ requested a review from MabezDev March 28, 2024 07:10
@bjoernQ bjoernQ force-pushed the timers-runtime-isr-binding branch 2 times, most recently from 8609b7e to de14dd7 Compare April 2, 2024 12:36
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long for getting to this. I think most of my concerns have been resolved in the meantime, so for the sake of getting this merged LGTM!

@jessebraham jessebraham added this pull request to the merge queue Apr 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2024
@jessebraham
Copy link
Member

Looks like the HIL tests need updating

@bjoernQ bjoernQ force-pushed the timers-runtime-isr-binding branch from de14dd7 to febf92a Compare April 3, 2024 07:18
@bjoernQ bjoernQ added this pull request to the merge queue Apr 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 3, 2024
@bjoernQ bjoernQ added this pull request to the merge queue Apr 3, 2024
Merged via the queue into esp-rs:main with commit 256d719 Apr 3, 2024
@bjoernQ bjoernQ deleted the timers-runtime-isr-binding branch November 26, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants