Add Delay HIL test
#1415
Merged
Add Delay HIL test
#1415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
MabezDev
reviewed
Apr 12, 2024
There was a problem hiding this comment.
Hmm, I'm wondering if we can test the opposite as well. For most delays what's important is that the delay waits at least as the long as specified. Waiting for longer is much less important than waiting for less than specified. I don't have a good idea on how to test that though.
|
As discussed in our last meeting, let's leave this open as draft until we have a solution to testing #1415 (review) |
|
I guess we could finish this off by doing something like this: https://github.com/esp-rs/esp-hal/pull/1503/files#diff-e59763db0f920701a0f837f4ad608deb797df5ffeb0adc976fc65eaecd1a2915R40-R42 we are sorta dependent on either breaking, but if either break we probably want to know? |
JurajSadel
force-pushed
the
hil-test-delay
branch
from
df00489 to
dbc6ab8
Compare
SergioGasquez
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
Adds an HIL test for Delay.
Not really sure, how useful these tests are though. Using the same value of delay as timeouts ends up in timeouts which is expected (correct me if I'm wrong). I used "random" delay values, maybe I can tune them a little bit but not sure if that make sense. Any feedback/suggestion is appreciated.
Testing
Run Delay test locally on multiple chip targets and manually triggered HIL job for this branch.