Skip to content

Conversation

@SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Apr 11, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • My changes were added to the CHANGELOG.md in the proper section.

Extra:

Pull Request Details 📖

Description

Adds an HIL test for SHA

Testing

Tested locally on S3 (required to use some changes of #1412), C6 and H2.

ESP32-S3 Output
     Running tests/sha.rs (target/xtensa-esp32s3-none-elf/debug/deps/sha-b2f1d22ba5d76ad5)
      Erasing ✔ [00:00:00] [##################################################################] 192.00 KiB/192.00 KiB @ 326.24 KiB/s (eta 0s )
  Programming ✔ [00:00:00] [#####################################################################] 48.76 KiB/48.76 KiB @ 49.45 KiB/s (eta 0s )    Finished in 1.597s

running 7 tests
test tests::test_sha_1       ... ok
test tests::test_sha_224     ... ok
test tests::test_sha_256     ... ok
test tests::test_sha_384     ... ok
test tests::test_sha_512     ... ok
test tests::test_sha_512_224 ... ok
test tests::test_sha_512_256 ... ok

test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 3.30s
ESP32-C6 Output
     Running tests/sha.rs (target/riscv32imac-unknown-none-elf/debug/deps/sha-0ef72a0ebd885bd2)
      Erasing ✔ [00:00:00] [##################################################################] 192.00 KiB/192.00 KiB @ 629.50 KiB/s (eta 0s )
  Programming ✔ [00:00:00] [#####################################################################] 49.67 KiB/49.67 KiB @ 73.82 KiB/s (eta 0s )    Finished in 0.994s

running 3 tests
test tests::test_sha_1   ... ok
test tests::test_sha_224 ... ok
test tests::test_sha_256 ... ok

test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.48s
ESP32-H2 Output
     Running tests/sha.rs (target/riscv32imac-unknown-none-elf/debug/deps/sha-c0acbc88e4804f4a)
      Erasing ✔ [00:00:00] [##################################################################################] 192.00 KiB/192.00 KiB @ 1002.40 KiB/s (eta 0s )
  Programming ✔ [00:00:00] [######################################################################################] 45.16 KiB/45.16 KiB @ 65.61 KiB/s (eta 0s )    Finished in 0.896s

running 3 tests
test tests::test_sha_1   ... ERROR probe_rs::util::rtt: 
Error reading from RTT: The control block has been corrupted. write pointer is 560705263 while buffer size is 1024 for "up" channel 0 (defmt)
ok
test tests::test_sha_224 ... ERROR probe_rs::util::rtt: 
Error reading from RTT: The control block has been corrupted. write pointer is 1577470528 while buffer size is 1024 for "up" channel 0 (defmt)
ok
test tests::test_sha_256 ... ERROR probe_rs::util::rtt: 
Error reading from RTT: The control block has been corrupted. write pointer is 610487893 while buffer size is 1024 for "up" channel 0 (defmt)
ok

test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.45s

Manually triggered the HIL workflow: https://github.com/esp-rs/esp-hal/actions/runs/8644022372

@SergioGasquez SergioGasquez added the skip-changelog No changelog modification needed label Apr 11, 2024
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jessebraham jessebraham added this pull request to the merge queue Apr 11, 2024
Merged via the queue into esp-rs:main with commit 5d61074 Apr 11, 2024
@SergioGasquez SergioGasquez deleted the feat/hil-sha branch April 12, 2024 06:36
SergioGasquez added a commit to SergioGasquez/esp-hal that referenced this pull request Apr 12, 2024
* feat: Add missing cfg(test)

* feat: Initial SHA HIL test

* test: Test all the SHA modes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog No changelog modification needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants