Use esp_println in favour of the Serial peripheral wherever possible
#202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind of a dumb PR, but I'm going to be changing the interface for the Serial peripheral driver eventually anyway so these were going to need changing regardless.
The examples
hello_world,advanced_serial, andserial_interruptsexamples still use the Serial peripheral driver, as they are more or less demonstrating it. Any remaining examples were updated to useesp_println, and some had their output removed altogether when it wasn't necessary or it did not otherwise add to the example.Not really much to review here, but let me know if you have any comments.