Skip to content

Conversation

@jessebraham
Copy link
Member

@jessebraham jessebraham commented Jan 31, 2023

Closes #367 (I think 😁). It was already working on this system to begin with, I'll hop on my other computer in a bit and test it out there.

@jessebraham jessebraham requested a review from bjoernQ January 31, 2023 16:51
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Should do the trick - I guess we should call that on other targets as well since otherwise ROM functions like ets_delay won't work correctly but that's something for another day

@jessebraham
Copy link
Member Author

Tested on my other system and this seems to have resolved the linker error.

@jessebraham jessebraham merged commit 75f7394 into esp-rs:main Jan 31, 2023
@jessebraham jessebraham deleted the fixes/rom-functions branch January 31, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linker error with latest esp32c3-hal release

2 participants