Skip to content

Conversation

@bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Apr 20, 2023

This adds support for (some of) the functionality offered by DEBUG-ASSIST

  • bus write logging is not supported
    • I don't see how to create a sane and safe API for this
    • it didn't work
    • at least for ESP32-C3 the TRM chapter talks about a chapter which is not available yet / incomplete
  • SP monitoring is not available for ESP32-S3
    • while registers are there it acted weird
    • there is no TRM chapter about DEBUG-ASSIST

The code could be made more generic (e.g. regarding the two RAM regions and core 0 vs core 1) but in this case it probably wouldn't result in much less code plus it would make things a bit more confusing

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, examples appear to be working. Thanks!

@jessebraham jessebraham merged commit ab79b14 into esp-rs:main Apr 20, 2023
SergioGasquez pushed a commit to SergioGasquez/esp-hal that referenced this pull request Apr 21, 2023
* Add DEBUG-ASSIST functionality

* Reformat `lib.rs`

* Reformat ESP32-C2 example
i404788 pushed a commit to i404788/esp-hal that referenced this pull request Jul 22, 2023
* Add DEBUG-ASSIST functionality

* Reformat `lib.rs`

* Reformat ESP32-C2 example
@bjoernQ bjoernQ deleted the feature/debug-assist branch November 26, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants