Skip to content

Initial support for MCPWM in ESP32-H2 #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 16, 2023
Merged

Initial support for MCPWM in ESP32-H2 #544

merged 6 commits into from
May 16, 2023

Conversation

@SergioGasquez
Copy link
Member

Adds initial support for MCP and the mcpwm example.

Tested the mcpwm example and here is the output:
Screenshot from 2023-05-16 16-51-55

The PWM clock selection was set according to ESP-IDF source code

Thanks to @bjoernQ for the help!

jessebraham
jessebraham approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still waiting on hardware so can't verify it personally, but based on your LA results and the changes LGTM!

@jessebraham jessebraham merged commit a7e4400 into esp-rs:main May 16, 2023
@SergioGasquez SergioGasquez deleted the feature/esp32h2-mcpwm branch May 16, 2023 16:12
SergioGasquez added a commit to SergioGasquez/esp-hal that referenced this pull request Jun 9, 2023
@SergioGasquez
Initial support for MCPWM in ESP32-H2 (esp-rs#544)
85565f2 
* feat: ✨ Enable mcpwm peripheral

* feat: ✨ Initial support MCPWM

* fix: 🐛 Select the rigth clock

* fix: 🐛 Select the XTAL clock

* docs: 📝 Update changelog
i404788 pushed a commit to i404788/esp-hal that referenced this pull request Jul 22, 2023
@SergioGasquez @i404788
Initial support for MCPWM in ESP32-H2 (esp-rs#544)
003612f 
* feat: ✨ Enable mcpwm peripheral

* feat: ✨ Initial support MCPWM

* fix: 🐛 Select the rigth clock

* fix: 🐛 Select the XTAL clock

* docs: 📝 Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jessebraham jessebraham jessebraham approved these changes

@bjoernQ bjoernQ Awaiting requested review from bjoernQ

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SergioGasquez @jessebraham