Update esp-hal-procmacros package dependencies and features
#628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we could also remove my great contribution here: https://github.com/esp-rs/esp-hal/blob/2371c30542f9bf5d69fa11bde8bf25902f29f0f2/esp-hal-procmacros/src/lib.rs#L288C22-L292 |
Hah! Forgot about that, removed 😁 |
playfulFence
pushed a commit
to playfulFence/esp-hal
that referenced
this pull request
Sep 26, 2023
…#628) * Remove unnecessary `riscv` and `xtensa` features from proc macro crate * Update `darling` and `syn`, address breaking changes * Update CHANGELOG * Remove unneeded macro definition/invocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been putting this off for awhile, didn't end up being too bad to fix the build errors 😁
riscvandxtensafeatures from theesp-hal-procmacrospackagedarlingandsyndependencies to their latest versions, and addressed all breaking changesDid some basic testing with
embassy_*examples, seems to still be working as expected.