Skip to content

Add ESP32-S3 example #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2023
Merged

Add ESP32-S3 example #1

merged 1 commit into from
Apr 13, 2023

Conversation

@bjoernQ
Copy link
Collaborator

@bjoernQ bjoernQ commented Apr 12, 2023

Add ESP32-S3 example and some cleanup.
This needs a recent commit of esp-wifi

JurajSadel
JurajSadel approved these changes Apr 13, 2023
View reviewed changes
Copy link

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tested all examples and they are working correctly, only one note, be sure you are using --release.

@bjoernQ bjoernQ merged commit c18f4d1 into main Apr 13, 2023
@bjoernQ bjoernQ deleted the add-esp32s3-example branch April 13, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JurajSadel JurajSadel JurajSadel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bjoernQ @JurajSadel