Skip to content
This repository was archived by the owner on May 23, 2024. It is now read-only.

Conversation

jessebraham
Copy link
Member

@jessebraham jessebraham commented Nov 22, 2022

This PR is a little all over the place, but essentially:

  • Fixed error message in build script
  • Consolidated the print! and println! macro implementations
  • Moved each implementation of the Write trait into a module, along with any required constants (fixes UART_TX_ONE_CHAR is never used when using RTT #21 and just generally cleans up the #[cfg]s)
  • Add a rustfmt.toml configuration file (closes Add an autoformatter #24)
  • Add a CI workflow which builds the library in each possible configuration and checks the code formatting

Successful CI run can be seen here on my fork.

@jessebraham jessebraham requested a review from bjoernQ November 22, 2022 16:56
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, CI checks! LGTM

@bjoernQ bjoernQ merged commit cf9720e into esp-rs:main Nov 22, 2022
@jessebraham jessebraham deleted the fixes/housekeeping branch November 22, 2022 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an autoformatter UART_TX_ONE_CHAR is never used when using RTT

2 participants