Skip to content
This repository was archived by the owner on Jun 23, 2025. It is now read-only.

Conversation

@SergioGasquez
Copy link
Member

  • Update the format of the files and the resulting format
  • Add checks in CI for all the targets
  • I tried having some is_xtensa and is_riscv variables, but the only solution that I found was having this "header" on all the files
    • All the changes are in the fix/chip-scalability branch
    • As this was a pretty ugly solution, what I did to facilitate the addition of new chips is to update the if check. As we don't have any plans for releasing new Xtensa chips, it should be easier this way.

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good overall, sorry for taking so long to get to this. Just a couple comments.

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MabezDev MabezDev merged commit 1114e40 into esp-rs:main Jan 30, 2023
@SergioGasquez SergioGasquez deleted the fix/update-conditions branch January 31, 2023 08:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants