Skip to content

Conversation

@bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Feb 22, 2023

This adjusts the code to work with the currently released HAL

TODO

  • needs a bugfixed ESP32-C2 HAL
  • none of the examples work on ESP32-S3 anymore
  • ESP32-C2 BLE example only works in opt-level 2

Closes #138

@MabezDev
Copy link
Member

re the c2 issues, did you see my comment in #114 (comment) - it might be a stack size issue?

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Feb 22, 2023

I tried increasing the task's stack to 16k each and still have 77k free for the stack but still only working with opt-level 2
That's really weird

@MabezDev
Copy link
Member

Really weird, perhaps we have some small UB in esp-wifi? I find it hard to believe the riscv32 toolchain is broken :D.

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Feb 22, 2023

Really weird, perhaps we have some small UB in esp-wifi? I find it hard to believe the riscv32 toolchain is broken :D.

Same here and I think that especially the NPL BLE stuff in esp-wifi still contains some issues so I'm fine with having it currently only working in opt-level 2 - something we need to investigate together with #114

ESP32-S3 is certainly a different thing - maybe worth to try disabling the loop-optimization

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Feb 22, 2023

Whole smoketest.bat works now again
Only thing left from my point of view is it needs the ESP32-C2 HAL patched - once that is resolved this should be fine

@bjoernQ bjoernQ marked this pull request as ready for review February 23, 2023 08:16
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bjoernQ bjoernQ merged commit a4d6452 into main Feb 23, 2023
@bjoernQ bjoernQ deleted the adjust-for-updated-hal branch February 23, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to latest published HALs

3 participants