Add more configuration options #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
reviewed
Aug 10, 2023
esp-wifi/src/lib.rs
Outdated
| #[allow(unused)] | ||
| #[cfg(all(coex, not(feature = "big-heap")))] | ||
| const HEAP_SIZE: usize = 64 * 1024; | ||
| const DEFAULT_HEAP_SIZE: usize = 64 * 1024; |
There was a problem hiding this comment.
coex check seems redundant on this one and above (one is coex & big heap, other is !coex & big_heap, both with the same value), in case you want to simplify :)
There was a problem hiding this comment.
true - most probably I will remove the big-heap feature and only have two defaults which somehow work everywhere ... we don't need to find the one best value (which doesn't exist for every one and every situation) anymore since it's now configurable
bjoernQ
force-pushed
the
feature/more-configs
branch
from
7664167 to
a181fcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to configure
Probably seems odd we keep the
big-heapfeature for now. It is to not immediately and unnecessarily breakesp-mbedtlsand depending code