Skip to content

Conversation

@JurajSadel
Copy link
Contributor

closes #170

This PR builds artifacts for cargo-espflash and espflash for Linux armv7 and armv7 (aarch68).
I wasn't successful with cross.

@JurajSadel JurajSadel requested a review from jessebraham May 20, 2022 12:52
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, sorry in the delay for reviewing!

I did notice that unfortunately both the espflash-aarch64-unknown-linux-gnu.zip and espflash-armv7-unknown-linux-gnueabihf.zip files seem to be missing the binaries (they're only 22 bytes, which indicates an empty archive). If you're able to resolve this I'm otherwise pretty happy with this.

@JurajSadel
Copy link
Contributor Author

That makes sense, I zipped espflash before build :D Should be fixed, thank you @jessebraham

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that!

@jessebraham jessebraham merged commit 55bce33 into esp-rs:master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build release artifacts for the Raspberry Pi

2 participants