Skip to content

Conversation

jessebraham
Copy link
Member

@jessebraham jessebraham commented Jul 4, 2022

Closes #201

@jessebraham jessebraham requested a review from bjoernQ July 4, 2022 16:45
@bjoernQ
Copy link
Contributor

bjoernQ commented Jul 4, 2022

Looks good / will test that tomrorrow but just FYI the probe-rs project has an interesting solution for this:

https://github.com/probe-rs/probe-rs/blob/67a180fcb6121b60b2dd27930d05cc6cc88ca669/cli/src/main.rs#L96
https://github.com/probe-rs/probe-rs/blob/67a180fcb6121b60b2dd27930d05cc6cc88ca669/cli/src/main.rs#L490

They use https://crates.io/crates/parse_int and a custom CLAP parse function. Didn't knew that is possible but looks like a good alternative

@jessebraham
Copy link
Member Author

Oh interesting, wasn't aware of that approach. Thanks! I'll probably re-work it to go that route instead.

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjoernQ bjoernQ merged commit c4a7228 into esp-rs:master Jul 5, 2022
@jessebraham jessebraham deleted the fixes/write-bin branch July 5, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The write-bin-to-flash subcommand should accept hex or decimal addresses

2 participants