Remove the espmonitor dependency, re-implement our own monitor
#254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately since `espmonitor` is licensed under GPL we are no longer able to use it after the relicensing
bjoernQ
reviewed
Oct 5, 2022
bjoernQ
approved these changes
Oct 5, 2022
MabezDev
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately since
espmonitoris licensed under GPL we are no longer able to use it after the relicensing. This adds back in some of the code which was removed when addingespmonitor, and then re-implements the necessary functionality to get us back to where we were.One added benefit of this new implementation is that
print!()actually works now, as we do not buffer until a newline likeespmonitordoes.Closes #253.