Skip to content

Conversation

jessebraham
Copy link
Member

  • Extracted an action to set up an ARM build environment to make the workflow simpler to read
  • All existing actions now run on ubuntu-22.04
  • We now additionally check the binary build on macos-12 and windows-22
  • The CI workflow files have been renamed to be consistent with other repos in the org

I like that the workflows now both follow the same structure and are fairly easy to grok. The downside is that we have a fair bit of duplicated YAML, but given how infrequently these files need changing IMO it's a worthwhile sacrifice.

@SergioGasquez if you have any feedback or opinions on this please let me know!

I will update the package workflows in a later PR.

@jessebraham jessebraham requested a review from SergioGasquez May 31, 2023 18:28
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The CI now looks way better!

@jessebraham jessebraham merged commit 151ca29 into esp-rs:main Jun 1, 2023
@jessebraham jessebraham deleted the fixes/ci branch June 1, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants