Skip to content

Add missing import when using linux and musl #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2023
Merged

Add missing import when using linux and musl #420

merged 1 commit into from
Jun 1, 2023

Conversation

jessebraham
Copy link
Member

Found this when updating the release workflow, will have to update our CI to check musl as well (I'll take care of that in another PR)

SergioGasquez
SergioGasquez approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks also for adding musl to the CI, so we avoid this in the future!

@jessebraham jessebraham merged commit a045f53 into esp-rs:main Jun 1, 2023
@jessebraham jessebraham deleted the fixes/musl branch June 1, 2023 16:02
@jessebraham jessebraham mentioned this pull request Jun 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SergioGasquez SergioGasquez SergioGasquez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jessebraham @SergioGasquez