Evaluate merging CI files #438
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for looking into this! At first glance I think this actually looks quite good. I was expecting I will do a proper review when I get a chance but I expect it's likely fine as-is. |
|
I like the idea of this one. I was recently bouncing between the two CI workflows while debugging a CI issue and wondering why they were split. |
|
Sorry it's been awhile 😅 I think this looks fine, if you wouldn't mind updating it (our workflow has changed since this PR was opened, so we need to be careful to reflect those changes) then I think we can merge this. Please just convert this from a draft and request a review when you're ready! |
Merged
|
Closed in favor of #470 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.