Skip to content

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Sep 29, 2023

  • Update dependencies
  • Update CHANGELOG
  • Bump espflash and cargo-espflash version

@MabezDev
Copy link
Member

I forget which library it is, but cc: @bjoernQ for the windows terminal issue just in case.

@bjoernQ
Copy link
Contributor

bjoernQ commented Sep 29, 2023

The problematic crate on Windows is crossterm - since this leaves it on 0.25.0 it should be fine.

We could update it with a workaround like described in #418 (comment) .... but that workaround probably needs to be tested on other OSs or only get applied for Windows builds

But maybe leave it out of this PR and have a separate one for that

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once little thing but otherwise LGTM, thanks for taking care of this!

Co-authored-by: Jesse Braham <[email protected]>
@SergioGasquez SergioGasquez merged commit 652740e into esp-rs:main Oct 3, 2023
@SergioGasquez SergioGasquez deleted the feat/update-deps branch October 3, 2023 15:30
SergioGasquez added a commit to SergioGasquez/espflash that referenced this pull request Oct 5, 2023
* build: Update dependendencies

* docs: Update changelog

* build: Update espflash and cargo-espflash version

* fix: Update clap version to avoid bumping MSRV

* build: Revert updating toml to avoid updating MSRV

* build: Update dependendencies

* build: Bump MSRV

* Unping espflash version

Co-authored-by: Jesse Braham <[email protected]>

* docs: Update changelog

---------

Co-authored-by: Jesse Braham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants