Use esp-flasher-stub stubs
#518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Given how untested the stubs are, this has the potential to induce a bunch of bug reports. Do we want to add them behind a flag first? |
I initially did that, but as Jesse suggested, not sure how many people will test it if it's behind a feature. Happy to revert the lats commit and keep it behind a flag, though. |
True, presumably there will be a rc release for espflash 3.0, so I guess if many people run into issues with the rc we can revisit the decision. |
MabezDev
approved these changes
Nov 22, 2023
SergioGasquez
force-pushed
the
feat/rust-stub
branch
from
b71a519 to
f093307
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
esp-flasher-stubgenerated stubs.esp-flasher-stubdoes not generate ESP8266 stubs so I kept the C based stub for it