Address library feedback #901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JurajSadel
approved these changes
Jun 24, 2025
JurajSadel
reviewed
Jun 24, 2025
MabezDev
force-pushed
the
lib-improve
branch
2 times, most recently
from
4c6b0d3 to
55ddb17
Compare
MabezDev
commented
Jun 25, 2025
|
|
||
| env: | ||
| CARGO_TERM_COLOR: always | ||
| RUST_LOG: debug |
There was a problem hiding this comment.
I can remove this, but I think it's quite useful when things go wrong. If a different level is better, let me know.
There was a problem hiding this comment.
No strong feelings either way, only usually check the CI logs when things fail anyway so probably makes sense to keep it in, at least for now.
| fi | ||
| echo "Writing binary" | ||
| result=$(timeout 45 espflash write-bin --monitor 0x0 app.bin --non-interactive 2>&1) | ||
| result=$(timeout 90 espflash write-bin --monitor 0x0 app.bin --non-interactive 2>&1) |
There was a problem hiding this comment.
This looks like I'm trying to hide the issue, but I believe that now verify and skip are respected, they are now used by default. This adds time to CI, and on some chips this takes longer than 45s.
There was a problem hiding this comment.
The same for the timeout in the hi.yml
jessebraham
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commandand friends available outside the connection structure.self.verifyandself.skipflash onFlasher