Skip to content

Improve CI and fix examples #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 24, 2023
Merged

Improve CI and fix examples #135

merged 12 commits into from
Feb 24, 2023

Conversation

SergioGasquez
Copy link
Member

  • CI is now run in parallel
  • Examples are now tested in CI
  • Some examples were not building

@SergioGasquez SergioGasquez linked an issue Feb 24, 2023 that may be closed by this pull request
CI should cover examples #117
Closed
MabezDev
MabezDev approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking care of this :). One quick comment about a TODO but it's no big deal.

@SergioGasquez SergioGasquez merged commit d0b5b56 into esp-rs:main Feb 24, 2023
@SergioGasquez SergioGasquez deleted the feature/improve-ci branch February 24, 2023 13:47
@SergioGasquez SergioGasquez mentioned this pull request Mar 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MabezDev MabezDev MabezDev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI should cover examples

2 participants

@SergioGasquez @MabezDev