Skip to content

Update .cargo/config.toml #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 1, 2023
Merged

Update .cargo/config.toml #138

merged 12 commits into from
Mar 1, 2023

Conversation

SergioGasquez
Copy link
Member

  • Added espflash
  • Added custom runner
  • Cleaned some unnecessary comments
  • Add comment to explain ESP_IDF_TOOLS_INSTALL_DIR
  • Updated the book to use the custom runner
    • We should probably add a note on the book to explain the custom runner, so users do no think is magic

MabezDev
MabezDev reviewed Feb 27, 2023
View reviewed changes
@SergioGasquez SergioGasquez marked this pull request as ready for review March 1, 2023 11:56
MabezDev
MabezDev approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SergioGasquez SergioGasquez merged commit 56301d1 into esp-rs:main Mar 1, 2023
@SergioGasquez SergioGasquez deleted the feature/config-update branch March 1, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MabezDev MabezDev MabezDev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SergioGasquez @MabezDev