Skip to content

Add cfg.toml checks #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 8, 2023
Merged

Add cfg.toml checks #144

merged 3 commits into from
Mar 8, 2023

Conversation

@SergioGasquez
Copy link
Member

  • Check if the cfg.toml file exists
  • Check that the values in cfg.toml are not the default ones

@SergioGasquez SergioGasquez linked an issue Mar 1, 2023 that may be closed by this pull request
Add Wifi credentials checks to build.rs #143
Closed
@SergioGasquez SergioGasquez requested a review from MabezDev March 1, 2023 15:27
MabezDev
MabezDev approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, some how this dropped off my radar! LGTM, thanks!

@SergioGasquez SergioGasquez merged commit ed94e8f into esp-rs:main Mar 8, 2023
@SergioGasquez SergioGasquez deleted the feature/build-checks branch March 8, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MabezDev MabezDev MabezDev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Wifi credentials checks to build.rs

2 participants

@SergioGasquez @MabezDev