Fix CI pipeline & devcontainer setup #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 17, 2022 10:44
* split commands to install Rust and use cargo * install Rust with minimal profile * use `slim` base image * remove installation from a few packages
justahero
force-pushed
the
minimize-docker-image-size
branch
from
b92649e to
ef9e504
Compare
added 4 commits
May 17, 2022 10:46
Github Actions do not support a shell using TTY, therefore this option is removed from the shell command.
The `Dockerfile` is built with the default `root` user. This is to support a successful Docker build on Github CI. Github Actions have a few restrictions, for example `USER` & `WORKDIR` directives should not be used. * refactor Dockerfile, remove `USER` & `WORKDIR` directives * fix VS Code devcontainer config * use `root` user * fix workspace folder location * update extensions * code formating * adjust Github CI config to build Docker image * update book instructions on Docker
* remove `bindgen` from Dockerfile
justahero
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Github CI workflow to build the Docker image in
.devcontainer/Dockerfile. The Docker image is now built fully, all Rust projects are compiled within the image.Due to a few restrictions when building a Docker image using Github Actions, the
Dockerfilehas been updated to avoid issues withUSER&WORKDIRinstructions.Dockerfileto work on Github CI & as a VS Code devcontainerbullseye-slimbase image, remove unnecessary packages