Make exceptions off by default #5538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scripts, makefiles, and users who do no changes will not have exceptions enabled during builds. This should avoid the sketch inflation issue for users who are space constrained, while allowing users who care about exceptions to enable them through the IDE.
d-a-v
approved these changes
Dec 21, 2018
devyte
approved these changes
Dec 21, 2018
earlephilhower
added a commit
to earlephilhower/Arduino
that referenced
this pull request
Dec 26, 2018
PR esp8266#5538 made exceptiond disabled by default and changed some file names which not get updated in the linker file, resultin in exceptions ending up back in IRAM.
earlephilhower
added a commit
that referenced
this pull request
Dec 26, 2018
PR #5538 made exceptions disabled by default and changed some file names which didn't get updated in the linker file, resulting in exceptions ending up back in IRAM.
6 tasks
ivankravets
added a commit
that referenced
this pull request
Feb 23, 2019
earlephilhower
pushed a commit
that referenced
this pull request
Feb 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scripts, makefiles, and users who do no changes will not have exceptions
enabled during builds. This should avoid the sketch inflation issue for
users who are space constrained, while allowing users who care about
exceptions to enable them through the IDE.