-
Notifications
You must be signed in to change notification settings - Fork 7.7k
fix(wifi): Workaround bug in esp_wifi_get_protocol() #11239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello me-no-dev, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Test Results 76 files 76 suites 13m 29s ⏱️ Results for commit e65dd57. ♻️ This comment has been updated with latest results. |
This pull request includes changes to the
WiFiGenericClass::modemethod in theWiFiGeneric.cppfile. The changes involve updating the data type of thecurrent_protocolvariable and modifying the way its address is passed to theesp_wifi_get_protocolfunction. This is required, becauseesp_wifi_get_protocolsets more than one byte in the provided return mask.Data type and casting updates:
current_protocolfromuint8_ttouint32_tto accommodate a wider range of values.esp_wifi_get_protocolfunction calls to cast the address ofcurrent_protocoltouint8_t*to match the expected parameter type. [1] [2]Fixes: #11218