Skip to content

Conversation

@trianglesphere
Copy link
Contributor

Description

TestConfirmationDepth was consistently failing on the HTTP versions of the op-e2e test. It was failing at the last line that checked the verifier head block timestamp against the L1 head timestamp. I have changed it to compare the verifier L1 Origin number against the L1 head number.
Tests

Ran several times in CI & this seems less flaky.

Metadata

  • Fixes ENG-3013

TestConfirmationDepth was consistently failing on the HTTP versions of the
op-e2e test. It was failing at the last line that checked the verifier
head block timestamp against the L1 head timestamp. I have changed it to
compare the verifier L1 Origin number against the L1 head number.
@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2022

⚠️ No Changeset found

Latest commit: 911b088

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot mentioned this pull request Nov 11, 2022
@mslipper
Copy link
Collaborator

Going to merge this in an effort to reduce CI failures.

@mslipper mslipper merged commit 3ee0a6c into develop Nov 11, 2022
@mslipper mslipper deleted the jg/l1_conf_depth_test branch November 11, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants