Skip to content

Conversation

@trianglesphere
Copy link
Contributor

Description

This adds support for the generalized index & tests for the position object.

Tests

Adds lots of tests.

@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2023

⚠️ No Changeset found

Latest commit: 6067559

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 6067559
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64935ecb32e80500081e5f70

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #6086 (6067559) into develop (8ab4ffe) will decrease coverage by 0.75%.
The diff coverage is 61.76%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6086      +/-   ##
===========================================
- Coverage    45.44%   44.70%   -0.75%     
===========================================
  Files          434      304     -130     
  Lines        28005    23291    -4714     
  Branches       688        0     -688     
===========================================
- Hits         12728    10412    -2316     
+ Misses       14247    11920    -2327     
+ Partials      1030      959      -71     
Flag Coverage Δ
bedrock-go-tests 44.70% <61.76%> (+0.04%) ⬆️
cannon-go-tests ?
common-ts-tests ?
contracts-bedrock-tests ?
core-utils-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-challenger/fault/cmd/main.go 0.00% <0.00%> (ø)
op-challenger/fault/position.go 47.82% <70.00%> (+47.82%) ⬆️

... and 131 files with indirect coverage changes

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@trianglesphere trianglesphere merged commit e2d3e59 into develop Jun 21, 2023
@trianglesphere trianglesphere deleted the jg/position branch June 21, 2023 20:50
@mergify mergify bot removed the on-merge-train label Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants