Skip to content

Update EIP-4844: Sync MAX_VERSIONED_HASHES_LIST_SIZE to 2**12 #6503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Update EIP-4844: Sync MAX_VERSIONED_HASHES_LIST_SIZE to 2**12 #6503

wants to merge 2 commits into from

Conversation

@etan-status
Copy link
Contributor

Align MAX_VERSIONED_HASHES_LIST_SIZE with LIMIT_BLOBS_PER_TX and MAX_TX_WRAP_KZG_COMMITMENTS changes from #6500.

assert len(versioned_hashes) == len(commitments) == len(blobs)

@etan-status
Update EIP-4844: Sync MAX_VERSIONED_HASHES_LIST_SIZE to 2**12
366df1a 
Align `MAX_VERSIONED_HASHES_LIST_SIZE` with `LIMIT_BLOBS_PER_TX` and
`MAX_TX_WRAP_KZG_COMMITMENTS` changes from ethereum#6500.

```python
assert len(versioned_hashes) == len(commitments) == len(blobs)
```
@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft s-review This EIP is in Review t-core labels Feb 15, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 15, 2023 •
edited
Loading

File EIPS/eip-4844.md

Requires 1 more reviewers from @adietrichs, @asn-d6, @dankrad, @Inphi, @lightclient, @protolambda, @vbuterin

@etan-status etan-status marked this pull request as ready for review April 27, 2023 20:32
@etan-status etan-status requested a review from eth-bot as a code owner April 27, 2023 20:32
@eth-bot eth-bot added the a-review Waiting on author to review label Apr 27, 2023
@roberto-bayardo roberto-bayardo mentioned this pull request May 1, 2023
Closed
g11tech
g11tech reviewed May 1, 2023
View reviewed changes
EIPS/eip-4844.md
| `MIN_DATA_GASPRICE` | `1` |
| `DATA_GASPRICE_UPDATE_FRACTION` | `2225652` |
| `MAX_VERSIONED_HASHES_LIST_SIZE` | `2**24` |
| `MAX_VERSIONED_HASHES_LIST_SIZE` | `2**12` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `MAX_VERSIONED_HASHES_LIST_SIZE` | `2**12` |
| `MAX_TX_VERSIONED_HASHES_LIST_SIZE` | `2**12` |

should we also add _TX_ to sort of correspond with other limits?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think aligning the values and renaming them should be separate discussions / PRs.

@g11tech
Copy link
Contributor

g11tech commented May 2, 2023

I think an approval is required from one of the authors

@lightclient
Copy link
Member

closing this as we are no longer pursuing SSZ in 4844

@etan-status etan-status deleted the tx-syncblobslimit branch May 30, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@g11tech g11tech g11tech approved these changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees

No one assigned

Labels

a-review Waiting on author to review c-update Modifies an existing proposal s-draft This EIP is a Draft s-review This EIP is in Review t-core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@etan-status @eth-bot @g11tech @lightclient